Add python wrapper for Adadelta optimizer #9213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghaoshuang
requested review from
chengduoZH,
guoshengCS,
pkuyym,
qingqing01 and
wanghaox
qingqing01
reviewed
Mar 20, 2018
|
|
||
| class AdadeltaOptimizer(Optimizer): | ||
| """Simple Adadelta optimizer with average squared grad state and | ||
| average squared update state. |
There was a problem hiding this comment.
python/paddle/fluid/optimizer.py
Outdated
| def __init__(self, learning_rate, epsilon=1.0e-6, rho=0.95, **kwargs): | ||
| assert learning_rate is not None | ||
| assert epsilon is not None | ||
| assert rho is not None |
There was a problem hiding this comment.
Better to use raise not assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9212