Skip to content

Conversation

putcn
Copy link
Contributor

@putcn putcn commented Mar 15, 2018

fix: #9133
math_function is missing from dep list of selected_rows, which leads to compile error in manylinux's blas builds.

https://paddleci.ngrok.io/viewLog.html?tab=buildLog&buildTypeId=Manylinux1_CpuAvxOpenblas&buildId=30547&_focus=2391

adding it back to fix this issue.

@putcn putcn requested review from Yancey0623 and luotao1 March 15, 2018 21:12
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Thanks very much!

@luotao1 luotao1 merged commit a448fbe into PaddlePaddle:develop Mar 16, 2018
@Yancey0623
Copy link
Contributor

Thanks so much, and it also fixed #8854.

@putcn putcn deleted the fix-selected-row-dep branch March 16, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpu_noavx_openblas build fails

3 participants