Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][D-[37-44]] Fix typos (dito,devide,documention,doens,doen,dobule,doubel,dowloading,downsteram) #70642

Merged
merged 8 commits into from
Jan 8, 2025
Merged

[CodeStyle][Typos][D-[37-44]] Fix typos (dito,devide,documention,doens,doen,dobule,doubel,dowloading,downsteram) #70642

merged 8 commits into from
Jan 8, 2025

Conversation

BaolanChen
Copy link
Contributor

PR Category

User Experience

PR Types

Devs

Description

fixed D[37-44]:
dito,
devide,
documention,
doens,
doen,
dobule,
doubel,
dowloading,
downsteram

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jan 6, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 6, 2025
@BaolanChen BaolanChen mentioned this pull request Jan 6, 2025
Merged
SigureMo
SigureMo requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

❯ typos               
error: `devide` should be `divide`, `device`
  --> ./test/ir/pir/cinn/llama_test_model.py:190:18
    |
190 |     # matmul and devide by sqrt(head_dim)
    |                  ^^^^^^
    |

没改全

paddle/phi/kernels/funcs/values_vectors_functor.h Outdated Show resolved Hide resolved
@BaolanChen BaolanChen requested a review from SigureMo January 6, 2025 11:36
@SigureMo SigureMo changed the title [CodeStyle][Typos][D-[37-44]] Fix typos (dito,devide,documention,doens,doen,dobule,doubel,dowloading,downsteram) [CodeStyle][Typos][D-[37-44]] Fix typos (dito,devide,documention,doens,doen,dobule,doubel,dowloading,downsteram) Jan 6, 2025
@SigureMo SigureMo mentioned this pull request Jan 6, 2025
Closed
@SigureMo
Copy link
Member

SigureMo commented Jan 6, 2025

冲突需要解决下

@BaolanChen
Copy link
Contributor Author

BaolanChen commented Jan 6, 2025 •
edited
Loading

冲突需要解决下

收到，冲突解决了

SigureMo
SigureMo requested changes Jan 6, 2025
View reviewed changes
_typos.toml Outdated
dobule = 'dobule'
Dowloading = 'Dowloading'
downsteram = 'downsteram'
dateset = 'dateset'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这冲突解决的不对啊，怎么还把别人删掉的加回来了？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到，理解错误了，已经修正commit了

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 7, 2025
@BaolanChen BaolanChen requested a review from SigureMo January 7, 2025 10:57
SigureMo
SigureMo approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo closed this Jan 8, 2025
@SigureMo SigureMo reopened this Jan 8, 2025
@luotao1 luotao1 merged commit 6b69d20 into PaddlePaddle:develop Jan 8, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@risemeup1 risemeup1 Awaiting requested review from risemeup1 risemeup1 is a code owner

@zhangbo9674 zhangbo9674 Awaiting requested review from zhangbo9674 zhangbo9674 is a code owner

@XieYunshen XieYunshen Awaiting requested review from XieYunshen XieYunshen is a code owner

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BaolanChen @SigureMo @luotao1