[SOT] Extract FrameProxy to separate file frame_proxy.h and frame_proxy.c
#69837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 29, 2024
paddle/fluid/pybind/sot/frame.h
Outdated
There was a problem hiding this comment.
要不叫 frame_proxy.h？
相关实现也顺带抽到 frame_proxy.c 吧
zrr1999
changed the title
PyInterpreterFrameProxy to separate file frame.hFrameProxy to separate file frame_proxy.h and frame_proxy.c
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- paddle/fluid/pybind/CMakeLists.txt: Language not supported
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/eval_frame.c: Language not supported
- paddle/fluid/pybind/sot/frame_proxy.c: Language not supported
- paddle/fluid/pybind/sot/frame_proxy.h: Language not supported
gouzil
reviewed
Nov 30, 2024
paddle/fluid/pybind/sot/eval_frame.c
Outdated
| @@ -38,112 +39,8 @@ limitations under the License. */ | |||
| // To avoid the error: undefined symbol: _PyFrame_GetFrameObject, all we need is | |||
| // to redefine this function based source code in python3.11. The advantage is | |||
| // that we don't need any modification in eval_frame functions. | |||
SigureMo
changed the title
FrameProxy to separate file frame_proxy.h and frame_proxy.cFrameProxy to separate file frame_proxy.h and frame_proxy.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
把 PyInterpreterFrameProxy 抽离到单独的文件