[SOT][3.13] Don't pass NULL to resume fn
#69735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
approved these changes
Nov 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
Python 3.13 因为 method 布局改了，不再能使用 #59297 的 trick 了，因此在 resume fn 的参数中排除掉 NULL，在抽的函数中如果需要
NULL，则直接PUSH_NULL，而不是通过输入传递目前只在 call breakgraph 和 if breakgraph 修改了，for 的场景还需要确认下
本 PR 确认修复了
test_numpy.py和test_min_graph_size.py，test_break_graph可能叠加 #69700 也修复了，避免冲突暂不修改白名单PCard-66972