[SOT][3.13] Use GetLocals to avoid SystemError when get locals from proxy frame
#69131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
GetLocals to avoid SystemError when get locals from proxy frameGetLocals to avoid SystemError when get locals from proxy frame
SigureMo
changed the title
GetLocals to avoid SystemError when get locals from proxy frameGetLocals to avoid SystemError when get locals from proxy frame
gouzil
approved these changes
Nov 3, 2024
SigureMo
deleted the
sot/use-get-locals-to-avoid-system-error-when-get-locals-from-proxy-frame
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
解决 #69126 中的遗留问题，
GetLocals到底需不需要的问题Python 3.13 中需要，而且可能每次都需要，因为每次都要创建一个代理 locals 以进行修改
但对于我们的 frame 代理来说是否可以缓存呢？因为我们的
frame.f_locals并不需要可以修改，这一点留待后续观察确认移动
test_numpy_addcase 到test_numpy中，不然每次从头适配的时候总是因为这个 case 导致test_01_basic在很后期才能支持目前本 PR 至少
test_01到test_03是可以直接通过了，具体通过情况待后续统计PCard-66972