Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CINN][New Hardware Update] HIP PR3 : add HIP backend #66109

Merged
merged 16 commits into from
Aug 9, 2024

Conversation

DongBaiYue
Copy link
Contributor

@DongBaiYue DongBaiYue commented Jul 16, 2024

PR Category

CINN

PR Types

New features

Description

HIP后端第三个PR

  • add hip codegen、compiler、runtime module
  • implement hip intrinsics without fp16

Pcard-67164

* add hip codegen、compiler、runtime module
* implement hip intrinsics without fp16
Copy link

paddle-bot bot commented Jul 16, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 16, 2024
paddle/cinn/backends/codegen_cuda_host.h Outdated Show resolved Hide resolved
paddle/cinn/backends/hip/codegen_hip_dev.h Show resolved Hide resolved
paddle/cinn/backends/hip/compiler_hip.cc Outdated Show resolved Hide resolved
Copy link

paddle-ci-bot bot commented Jul 28, 2024

Sorry to inform you that 4a6c08d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

tc20042008
tc20042008 previously approved these changes Aug 2, 2024
zyfncg
zyfncg previously approved these changes Aug 7, 2024
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for setup.py.in

@@ -194,7 +194,7 @@ llvm::Value* CodeGenCudaHost::LowerGPUKernelLauncher(
return function;
}

llvm::Value* CodeGenCudaHost::LowerCUDAKernelCall(const ir::Call* call_ir) {
llvm::Value* CodeGenCudaHost::LowerGPUKernelCall(const ir::Call* call_ir) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CudaHost里的cuda需要换成GPU吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR会将CodeGenCudaHost重命名为CodeGenGpuHost

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tc20042008 tc20042008 merged commit 1f6d619 into PaddlePaddle:develop Aug 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants