Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.117】add parameter value for thresholded_relu #60067

Closed
wants to merge 5 commits into from

Conversation

jinyouzhi
Copy link
Contributor

@jinyouzhi jinyouzhi commented Dec 15, 2023

PR types

New features

PR changes

APIs

Description

add thresholded_relu to improve the use of ease
#57262

Copy link

paddle-bot bot commented Dec 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

fix codestyle

fix comment
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Contributor

@jinyouzhi coverage CI没过

@luotao1
Copy link
Contributor

luotao1 commented Dec 19, 2023

需要提交对应的中文文档

@jinyouzhi
Copy link
Contributor Author

@jinyouzhi coverage CI没过

感谢大佬评审,有关 CPU 的代码Coverage能够覆盖到吗?不太确定这里怎么修改,是要增加测试用例来覆盖吗?
image

@luotao1
Copy link
Contributor

luotao1 commented Dec 20, 2023

CPU 的代码Coverage能够覆盖到,是要增加测试用例来覆盖

Copy link

paddle-ci-bot bot commented Jan 4, 2024

Sorry to inform you that c936f55's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants