add profiler_range #59634
Merged
add profiler_range #59634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
From00
reviewed
Dec 4, 2023
python/paddle/profiler/utils.py
Outdated
| return | ||
|
|
||
| try: | ||
| if (iter_id == start) or (iter_id >= start): |
There was a problem hiding this comment.
这个判断逻辑看起来很奇怪，而且在exit_after_prof==false的时候看起来是错的。
There was a problem hiding this comment.
这个判断逻辑看起来很奇怪，而且在
exit_after_prof==false的时候看起来是错的。
已修复
@contextmanager
def job_schedule_profiler_range(iter_id, start, end, exit_after_prof=True):
if start >= end:
yield False
return
try:
if iter_id >= start and iter_id < end:
yield True
else:
yield False
finally:
if iter_id == end - 1:
if exit_after_prof:
sys.exit()
python/paddle/profiler/utils.py
Outdated
|
|
||
|
|
||
| @contextmanager | ||
| def profiler_range(iter_id, start, end, exit_after_prof=True): |
There was a problem hiding this comment.
Suggested change
| def profiler_range(iter_id, start, end, exit_after_prof=True): | |
| def job_schedule_profiler_range(iter_id, start, end, exit_after_prof=True): |
done |
20 tasks
From00
approved these changes
Dec 7, 2023
| from paddle.profiler.utils import job_schedule_profiler_range | ||
|
|
||
|
|
||
| class TestJobScheDuleProfilerRange(unittest.TestCase): |
There was a problem hiding this comment.
Suggested change
| class TestJobScheDuleProfilerRange(unittest.TestCase): | |
| class TestJobScheduleProfilerRange(unittest.TestCase): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
添加 profiler_range 工具，方便 便捷地启用 profile 工具：
相关pr：