【Hackathon 5th No.103】 fix the bug in moving fc_mkldnn to phi -part #59531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
changed the title
luotao1
changed the title
yuanlehome
reviewed
Dec 26, 2023
paddle/phi/api/yaml/op_compat.yaml
Outdated
| extra : | ||
| [bool @ALL_KERNELS_MUST_COMPUTE_RUNTIME_SHAPE@ = true] | ||
| attrs : [bool use_mkldnn = false, bool use_quantizer = false, str mkldnn_data_type = "float32", float Scale_in = 1.0f, "float[] Scale_weights = {1.0f}", float Scale_out = 1.0f, bool force_fp32_output = false] |
There was a problem hiding this comment.
ALL_KERNELS_MUST_COMPUTE_RUNTIME_SHAPE需要加上
yuanlehome
reviewed
Dec 26, 2023
| @@ -100,7 +100,6 @@ const std::unordered_map<std::string, ExtraAttrPropertySet> | |||
| {"mkldnn_data_type", ExtraAttrProperty::ONEDNN}, | |||
| {"scale_x", ExtraAttrProperty::ONEDNN}, | |||
| {"scale_y", ExtraAttrProperty::ONEDNN}, | |||
| {"scale_out", ExtraAttrProperty::ONEDNN}, | |||
There was a problem hiding this comment.
这个，在下面有一个Scale_out，所以删除了scale_out
added 2 commits
December 26, 2023 08:03
cpu/gpu走的都是fc_kernel_impl.h，不需要改了哈～ |
chenwhql
approved these changes
Dec 27, 2023
heavengate
approved these changes
Dec 27, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
…addlePaddle#59531) * try to fix the bug in fc_mkldnn * fix the missing attr bug * fix the parameters bug * remove the paramars in pir * roback and add attr * add the scale_out --------- Co-authored-by: zeroRains <linjunlu@zerorains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix the bug in this pr #58777