Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify fluid submodules to fluid module #5924

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Nov 27, 2017

Fix #5876

Change books just use `import fluid`, not submodules
@reyoung reyoung requested a review from QiJune November 27, 2017 04:59
out = np.array(outs[0])
acc = np.array(outs[1])
out, acc = exe.run(inference_program,
feed={'x': x_data,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So executor run interface will create LoDTensor and set numpy data?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, we have a aslodtensor helper function now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executor can only create Tensor now. LoDTensor needs to be set manually.

Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, execellent work!

@reyoung reyoung merged commit 0ac8c74 into PaddlePaddle:develop Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants