Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Scale Compute to Support Mix Precision #58811

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

zhhsplendid
Copy link
Member

PR types

Bug fixes

PR changes

OPs

Description

pcard-77272
Modify Scale Compute to Support Mix Precision

out = Compute(
A->shape,
[=](const std::vector<Expr> &indice) {
Expr cast_scale = should_upscale_fp32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scale和bias默认应该都是fp32?是不是只需cast A就行

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 8f5e4b1 into PaddlePaddle:develop Nov 13, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Modify Scale Compute to Support Mix Precision
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Modify Scale Compute to Support Mix Precision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants