【Hackathon 5th No.104】move self_dp_attention to phi -part #58715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfncg
reviewed
Nov 7, 2023
| dim_input)); | ||
| DDim out_dims({dim_input[0], dim_input[1], dim_input[3], dim_input[4]}); | ||
| out->set_dims(out_dims); | ||
| out->share_lod(x); |
There was a problem hiding this comment.
这个头文件看上去没有被其他地方使用，是否可以直接写到kernel源文件中？
|
|
|
zerorains seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
move self_dp_attention op to phi move .h to the source reomove the head file
zeroRains
force-pushed
the
104_self_dp
branch
from
8559690
to
e468625
Compare
|
我确认下这个pr和另一个pr58300，单测都是正常跑过的对吧？ |
是的 |
zyfncg
approved these changes
Nov 9, 2023
sunzhongkai588
approved these changes
Nov 9, 2023
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
move self_dp_attention to phi
#57262