-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 5th No.31】 为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API #58280
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
✅ This PR's description meets the template requirements! |
Sorry to inform you that 9c1ecad's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atleast_1d/2d/3d实现了吗,也是这一期黑客松,复用的话代码维护成本更低些,建议复用
python/paddle/__init__.py
Outdated
@@ -883,6 +888,11 @@ | |||
"index_add_", | |||
"index_put", | |||
"index_put_", | |||
"column_stack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有类成员方式,这里不用导出
@@ -5124,6 +5124,302 @@ def index_put(x, indices, value, accumulate=False, name=None): | |||
return out | |||
|
|||
|
|||
def column_stack(x, name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果有别名的,直接a=b就可以,复用维护一套代码
column_stack row_stack应该是别名吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
底下的row_stack用的是vstack的别名
本身是在 atleast_1d/2d/3d实现的基础上,写的这一组代码,但是为了代码的清晰性,我把对应的atleast_1d/2d/3d,融合到了现有的函数里面,这样的话,就避免了耦合 |
Sorry to inform you that 3f7b609's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sorry to inform you that 2eb5aad's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
PR types
New features
PR changes
APIs
Description
add features for Hackathon 5th No.31 column_stack / row_stack / dstack / hstack / vstack API
RFC:PaddlePaddle/community#684