Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.31】 为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API #58280

Closed
wants to merge 8 commits into from

Conversation

bapijun
Copy link
Contributor

@bapijun bapijun commented Oct 20, 2023

PR types

New features

PR changes

APIs

Description

add features for Hackathon 5th No.31 column_stack / row_stack / dstack / hstack / vstack API
RFC:PaddlePaddle/community#684

@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 20, 2023
@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@luotao1 luotao1 changed the title 【Hackathon 5th No.33】 为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API 【Hackathon 5th No.31】 为 Paddle 新增 column_stack / row_stack / dstack / hstack / vstack API Oct 20, 2023
Copy link

paddle-ci-bot bot commented Nov 2, 2023

Sorry to inform you that 9c1ecad's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atleast_1d/2d/3d实现了吗,也是这一期黑客松,复用的话代码维护成本更低些,建议复用

@@ -883,6 +888,11 @@
"index_add_",
"index_put",
"index_put_",
"column_stack",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有类成员方式,这里不用导出

@@ -5124,6 +5124,302 @@ def index_put(x, indices, value, accumulate=False, name=None):
return out


def column_stack(x, name=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果有别名的,直接a=b就可以,复用维护一套代码

column_stack row_stack应该是别名吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底下的row_stack用的是vstack的别名

@bapijun
Copy link
Contributor Author

bapijun commented Nov 8, 2023

atleast_1d/2d/3d实现了吗,也是这一期黑客松,复用的话代码维护成本更低些,建议复用

本身是在 atleast_1d/2d/3d实现的基础上,写的这一组代码,但是为了代码的清晰性,我把对应的atleast_1d/2d/3d,融合到了现有的函数里面,这样的话,就避免了耦合

Copy link

paddle-ci-bot bot commented Nov 13, 2023

Sorry to inform you that 3f7b609's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link

paddle-ci-bot bot commented Nov 27, 2023

Sorry to inform you that 2eb5aad's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1 luotao1 closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants