Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.1】 为 Paddle 新增 copysign API #57426

Closed
wants to merge 0 commits into from
Closed

【Hackathon 5th No.1】 为 Paddle 新增 copysign API #57426

wants to merge 0 commits into from

Conversation

cocoshe
Copy link
Contributor

@cocoshe cocoshe commented Sep 17, 2023

PR types

New features

PR changes

APIs

Description

为Paddle新增copysign API
RFC: paddle.copysign 设计文档

主要代码已完成,但是grad计算还存在问题,测试backward时出现问题,check_grad()相关文档似乎较少,希望reviewers可以帮忙指点一下~感谢

root@autodl-container-81914db329-c47db06c:~/autodl-tmp/Paddle/build# ctest -R test_copysign_op -V
UpdateCTestConfiguration  from :/root/autodl-tmp/Paddle/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/root/autodl-tmp/Paddle/build/DartConfiguration.tcl
Test project /root/autodl-tmp/Paddle/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 804
    Start 804: test_copysign_op

804: Test command: /usr/local/bin/cmake "-E" "env" "PYTHONPATH=/root/autodl-tmp/Paddle/build/python" "/root/miniconda3/bin/python3" "/root/autodl-tmp/Paddle/tools/test_runner.py" "test_copysign_op"
804: Working Directory: /root/autodl-tmp/Paddle/build/test/legacy_test
804: Test timeout computed to be: 10000000
804: W0918 05:25:31.859818 22924 gpu_resources.cc:119] Please NOTE: device: 0, GPU Compute Capability: 8.6, Driver API Version: 12.2, Runtime API Version: 11.3
804: W0918 05:25:31.863019 22924 gpu_resources.cc:149] device: 0, cuDNN Version: 8.2.
804: I0918 05:25:31.874296 22924 program_interpreter.cc:136] New Executor is Running.
804: WARNING: OMP_NUM_THREADS set to 12, not 1. The computation speed will not be optimized if you use data parallel. It will fail if this PaddlePaddle binary is compiled with OpenBlas since OpenBlas does not support multi-threads.
804: PLEASE USE OMP_NUM_THREADS WISELY.
804: test_copysign_op failed
804:  ...............E..............
804: ======================================================================
804: ERROR: tearDownClass (test_copysign_op.TestCopySignOp)
804: ----------------------------------------------------------------------
804: Traceback (most recent call last):
804:   File "/root/autodl-tmp/Paddle/build/test/legacy_test/eager_op_test.py", line 476, in tearDownClass
804:     raise AssertionError(
804: AssertionError: This test of copysign op needs check_grad with fp64 precision.
804: 
804: ----------------------------------------------------------------------
804: Ran 29 tests in 1.696s
804: 
804: FAILED (errors=1)
804: 
1/1 Test #804: test_copysign_op .................***Failed    4.37 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   4.43 sec

The following tests FAILED:
        804 - test_copysign_op (Failed)
Errors while running CTest
Output from these tests are in: /root/autodl-tmp/Paddle/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 25, 2023

Sorry to inform you that e2ca9c9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zoooo0820
Copy link
Contributor

@cocoshe 检查下OpTest类中的_check_grad_helper函数中逻辑是否正确设置了fp64相关的属性。此外流水线信息显示还有其他错误,也需要修正下排除这部分的干扰

@cocoshe
Copy link
Contributor Author

cocoshe commented Sep 25, 2023

@cocoshe 检查下OpTest类中的_check_grad_helper函数中逻辑是否正确设置了fp64相关的属性。此外流水线信息显示还有其他错误,也需要修正下排除这部分的干扰

收到,修正ing

@cocoshe cocoshe closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants