Skip to content

Fix ci not exit 1 when error #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2017
Merged

Fix ci not exit 1 when error #5431

merged 4 commits into from
Nov 7, 2017

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Nov 7, 2017 •
edited by luotao1
Loading

fix #5432

@typhoonzero typhoonzero requested a review from luotao1 November 7, 2017 09:29
luotao1
luotao1 previously approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Nov 7, 2017

I pull the code, and test it successfully on my server

luotao1
luotao1 previously approved these changes Nov 7, 2017
View reviewed changes
@typhoonzero
Copy link
Contributor Author

Seem CI failed at #5434 I'll disable it first to merge this fix

@luotao1 luotao1 merged commit 6f43c93 into PaddlePaddle:develop Nov 7, 2017
@typhoonzero typhoonzero deleted the fix_ci_build_check branch December 22, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compiler error in latest develop branch

3 participants

@typhoonzero @luotao1 @tonyyang-svail