Skip to content

Change the name of the export.map to paddle_capi.map which need to be… #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2017
Merged

Change the name of the export.map to paddle_capi.map which need to be… #4963

merged 1 commit into from
Oct 20, 2017

Conversation

hedaoyuan
Copy link
Contributor

@hedaoyuan hedaoyuan commented Oct 20, 2017 •
edited
Loading

… released in each version.

  1. Rename export.map and remove export.sym.
  2. paddle_capi.map need be released because users will use the static library to build their own dynamic library.

@hedaoyuan hedaoyuan requested review from Xreki and gongweibao October 20, 2017 07:13
gongweibao
gongweibao approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞！
LGTM！

@hedaoyuan hedaoyuan merged commit 9a5562a into PaddlePaddle:develop Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongweibao gongweibao gongweibao approved these changes

@Xreki Xreki Awaiting requested review from Xreki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedaoyuan @gongweibao