Skip to content

Change namespace of pybind.cc to pybind #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2017
Merged

Change namespace of pybind.cc to pybind #4334

merged 2 commits into from
Sep 22, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 22, 2017 •
edited
Loading

Fix #4335

JiayiFeng
JiayiFeng previously approved these changes Sep 22, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit d22956c into PaddlePaddle:develop Sep 22, 2017
@reyoung reyoung deleted the feature/change_namespace_for_pybind branch September 22, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @JiayiFeng