Skip to content

Add MKLDNN pool #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2017
Merged

Add MKLDNN pool #4140

merged 6 commits into from
Sep 19, 2017

Conversation

tensor-tang
Copy link
Contributor

resolve #4124

@tensor-tang tensor-tang requested a review from luotao1 September 16, 2017 14:15
@luotao1
Copy link
Contributor

luotao1 commented Sep 18, 2017

#4154 已经merge了,所有pooling都不计算padding,请更新下mkldnn的相关代码。

@tensor-tang
Copy link
Contributor Author

Done.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0});
LayerInputConfig* input = cfg.layerConfig.add_inputs();
PoolConfig* pool = input->mutable_pool_conf();
// pool->set_pool_type(poolType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释的行可以去掉。

@luotao1 luotao1 merged commit d4d4580 into PaddlePaddle:develop Sep 19, 2017
@tensor-tang tensor-tang deleted the mkldnn_pool branch September 19, 2017 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MKLDNNPoolLayer
2 participants