[Phi] Migrate cholesky_solve op to phi #40387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
changed the title
|
Thanks for your contribution! |
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
f975cc1 to
76ef141
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
76ef141 to
818d144
Compare
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
818d144 to
f83f084
Compare
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
f83f084 to
8d378b7
Compare
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
8d378b7 to
9f4fa87
Compare
| phi::funcs::ForRange<Context> out_for_range(dev_ctx, out->numel()); | ||
| phi::funcs::ConjFunctor<T> out_functor( | ||
| out->data<T>(), out->numel(), out->data<T>()); | ||
| out_for_range(out_functor); |
There was a problem hiding this comment.
这里可以直接调用phi::ConjKernel
| #include "paddle/phi/kernels/transpose_kernel.h" | ||
|
|
||
| // See Note [ Why still include the fluid headers? ] | ||
| #include "paddle/fluid/operators/tril_triu_op.h" |
There was a problem hiding this comment.
#40007 这个PR 将会删除这个头文件了，你看下如何解冲突？
There was a problem hiding this comment.
这个CI要过了，那个需要重新push，先合这个吧避免delay进度
| DenseTensor out_conj; | ||
| out_conj.Resize(out.dims()); | ||
| phi::funcs::ForRange<Context> out_for_range(dev_ctx, out.numel()); | ||
| phi::funcs::ConjFunctor<T> out_functor( |
There was a problem hiding this comment.
可以用phi::ConjKernel
| commonterm.data<T>(), | ||
| commonterm.numel(), | ||
| dev_ctx.template Alloc<T>(&commonterm_conj)); | ||
| commonterm_for_range(commonterm_functor); |
| const auto H = y_bst_dims_vec[y_bst_ndim - 2]; | ||
| const auto W = y_bst_dims_vec[y_bst_ndim - 1]; | ||
| phi::funcs::ForRange<Context> y_for_range(dev_ctx, dy_bst.numel()); | ||
| paddle::operators::TrilTriuCompute<T> tril_triu_functor( |
There was a problem hiding this comment.
TrilTriu 也正在迁移，看下如何避免冲突
已经合入了 |
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
9f4fa87 to
4af01b1
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
cholesky_solve_phi
branch
from
4af01b1 to
8c223cd
Compare
YuanRisheng
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
[Phi] migrate cholesky_solve op to phi.