Skip to content

Upgrade new profiler #39984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 2, 2022
Merged

Conversation

rainyfly
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  1. 优化了Chrometracing导出的timeline展示效果
  2. 加入了Extra info
  3. 加入暴露到python层的数据结构
  4. 根据所加入内容修改profiler.cc

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -45,9 +48,14 @@ std::unique_ptr<Profiler> Profiler::Create(const ProfilerOptions& options) {
Profiler::Profiler(const ProfilerOptions& options) {
options_ = options;
HostTracerOptions host_tracer_options;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HostTracerOptions host_tracer_options;挪到if (trace_switch.test(kProfileCPUOptionBit)里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

@@ -24,9 +24,12 @@
#include "paddle/fluid/platform/device/gpu/gpu_info.h"
#endif
#include "paddle/fluid/platform/enforce.h"
#include "paddle/fluid/platform/profiler/cpu_utilization.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个。h里include一次了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

liutiexing
liutiexing previously approved these changes Feb 28, 2022
liutiexing
liutiexing previously approved these changes Mar 1, 2022
Copy link
Contributor

@liutiexing liutiexing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChromeTracing has some bug

liutiexing
liutiexing previously approved these changes Mar 1, 2022
liutiexing
liutiexing previously approved these changes Mar 1, 2022
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 0c3f7fb into PaddlePaddle:develop Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants