-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Upgrade new profiler #39984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade new profiler #39984
Conversation
Thanks for your contribution! |
@@ -45,9 +48,14 @@ std::unique_ptr<Profiler> Profiler::Create(const ProfilerOptions& options) { | |||
Profiler::Profiler(const ProfilerOptions& options) { | |||
options_ = options; | |||
HostTracerOptions host_tracer_options; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HostTracerOptions host_tracer_options;挪到if (trace_switch.test(kProfileCPUOptionBit)里
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已改
@@ -24,9 +24,12 @@ | |||
#include "paddle/fluid/platform/device/gpu/gpu_info.h" | |||
#endif | |||
#include "paddle/fluid/platform/enforce.h" | |||
#include "paddle/fluid/platform/profiler/cpu_utilization.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个。h里include一次了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已改
… upgrade_new_profiler
… upgrade_new_profiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChromeTracing has some bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe