[PTen] Unify device context entrance in pten part 2 #38182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ql/Paddle into pten/unify_device_context_2
jiweibo
reviewed
Dec 16, 2021
| @@ -17,16 +17,13 @@ | |||
| // CUDA and HIP use same api | |||
| #if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP) | |||
|
|
|||
| #include "paddle/pten/backends/cuda/cuda_context.h" | |||
There was a problem hiding this comment.
目前看起来CUDAContext和ROCMContext实际90%成员变量函数都一样，只有少数cusolver等没对齐。
backends/cuda/cuda_context.h后续可以替换成backends/gpu/gpu_context.h似乎更合理，后续达成共识后可以在统一修改
There was a problem hiding this comment.
可以，我觉得kernels目录也从cuda换成gpu比较合理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
[PTen] Unify device context entrance in pten part 2
part 1：#38172