renorm op #38130
Merged
renorm op #38130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
jeff41404
reviewed
Dec 16, 2021
paddle/fluid/operators/renorm_op.cu
Outdated
Comment on lines
213
to
216
| TensorReduceFunctorImpl<T, T, CustomSum>(pow_value, &dim_value, reduce_axis, | ||
| stream); | ||
| TensorReduceFunctorImpl<T, T, CustomSum>(mul_value, &weight_derivative, | ||
| reduce_axis, stream); |
There was a problem hiding this comment.
Recently, this PR add the transformop parameter in TensorReduceFunctorImpl, it's better to have the same modification.
jeff41404
reviewed
Dec 16, 2021
paddle/fluid/operators/renorm_op.cu
Outdated
| UnsignedPowFunctor<MT, T>>( | ||
| cuda_ctx, ins, &outs, func); | ||
| std::vector<int> reduce_axis = {0, 2}; | ||
| TensorReduceFunctorImpl<T, T, CustomSum>(pow_value, &dim_value, reduce_axis, |
There was a problem hiding this comment.
Recently, this PR add the transformop parameter in TensorReduceFunctorImpl, it's better to have the same modification.
jeff41404
reviewed
Dec 16, 2021
python/paddle/tensor/math.py
Outdated
| @@ -1069,6 +1069,31 @@ def addmm(input, x, y, beta=1.0, alpha=1.0, name=None): | |||
| type="addmm", inputs=inputs, attrs=attrs, outputs={"Out": out}) | |||
| return out | |||
|
|
|||
| def renorm(input, p, dim, max_norm): | |||
There was a problem hiding this comment.
parameter "input" should be "x" like other Python API and "dim" should be "axis"
zmxdream
reviewed
Dec 22, 2021
TCChenlong
approved these changes
Dec 24, 2021
danleifeng
approved these changes
Dec 24, 2021
lanxianghit
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
renorm op