Skip to content

Conversation

@jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Sep 8, 2021

PR types

New features

PR changes

OPs

Describe

Added clip op BF16/FP32 FWD/BWD kernels for slot_rnn model.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jczaja
jczaja previously approved these changes Sep 9, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Sep 9, 2021

@piotrekobiIntel Could you please review this PR?

@ghost
Copy link

ghost commented Sep 9, 2021

LGTM

Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 4e23371 into PaddlePaddle:develop Sep 12, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* implemented clip op bf16/fp32

* added skipping if not cpu or bf16

* CI rerun after bf16 package change

* added parentheses to ensure formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants