Skip to content

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 7, 2021

PR types

Bug fixes

PR changes

OPs

Describe

Fix scatter_nd_add and gather bug when using large data. Use int64_t instead of int to avoid overflow.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 7, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 3c457a3 into PaddlePaddle:develop Sep 8, 2021
@sneaxiy sneaxiy deleted the fix_scatter_nd_bug branch September 8, 2021 04:07
2742195759 pushed a commit to 2742195759/Paddle that referenced this pull request Sep 10, 2021
* fix scatter_add_nd and gather bug

* fix gather compile error
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* fix scatter_add_nd and gather bug

* fix gather compile error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants