support numpy dtype and polish code of list index. #35404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Sep 3, 2021
Comment on lines
591
to
598
| if not isinstance(item, (tuple, list)): | ||
| item = [item] | ||
|
|
||
| for slice_item in item: | ||
| if isinstance(slice_item, list): | ||
| if isinstance(slice_item, (list, tuple)): | ||
| return True | ||
| elif isinstance(slice_item, Variable): | ||
| return True |
There was a problem hiding this comment.
when item is a list, the return is False
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* support numpy dtype and polish code of list index. * polish code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
varbase._getitem__支持 np.longlong，np.int64，np.int32 ，np.int16