-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Collect LSTM quant model scales and save LSTM int8 #35382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. LGTM
c20d9bc to
933aefc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a compile error here. There is duplication of 2255 line. And broken formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thank you. I haved talke with Joanna, and removed those changes that she has add in her merged PR. Now I m just waiting for CIs to pass. Locally UT passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arogowie-intel Hi it passed CIs, please review again. Thanks.
933aefc to
7be9309
Compare
7be9309 to
3304a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@jczaja Hi, Please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Function optimization
PR changes
Others
Describe
Add fc lstm fuse pass, collect quant2 lstm scales and save lstm int8 model test