Skip to content

Conversation

@lidanqing-vv
Copy link
Contributor

PR types

Function optimization

PR changes

Others

Describe

Add fc lstm fuse pass, collect quant2 lstm scales and save lstm int8 model test

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-vv lidanqing-vv changed the title fc_lstm fuse pass,collect scales save lstm int8 models Add fc_lstm fuse pass,collect scales save lstm int8 Sep 2, 2021
@lidanqing-vv lidanqing-vv requested a review from wozna September 3, 2021 05:10
@lidanqing-vv lidanqing-vv requested a review from jczaja September 3, 2021 13:38
wozna
wozna previously approved these changes Sep 6, 2021
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM

Comment on lines 2256 to 2262
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a compile error here. There is duplication of 2255 line. And broken formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you. I haved talke with Joanna, and removed those changes that she has add in her merged PR. Now I m just waiting for CIs to pass. Locally UT passed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arogowie-intel Hi it passed CIs, please review again. Thanks.

Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv lidanqing-vv changed the title Add fc_lstm fuse pass,collect scales save lstm int8 Collect LSTM quant model scales and save LSTM int8 Sep 10, 2021
@lidanqing-vv
Copy link
Contributor Author

@jczaja Hi, Please review this PR.

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 1ee237c into PaddlePaddle:develop Sep 12, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants