[oneDNN] disable caching for interpolate and batch Norm #35030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jakpiase
reviewed
Aug 20, 2021
| auto out_dims_vec = ComputeOutputShape(ctx); | ||
| framework::DDim dim_out = framework::make_ddim(out_dims_vec); | ||
| z->mutable_data<T>(dim_out, ctx.GetPlace()); | ||
| z->Resize(dim_out); |
There was a problem hiding this comment.
Why did you earlier need this "mutable_data" call and why don't you need it now?
There was a problem hiding this comment.
Great question. mutable data is not needed here as it is called internally inside AcquireDstMemory so having it here(as deleted) was creating situation that it was called twice which was not needed and in some situations it could cause performance drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
PR is disabling caching oneDNN objects by PaddlePaddle cache (cache of oneDNN library will be used instead)