optimize index computation #33909
Merged
optimize index computation #33909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… roll_optimize_kernel
Xreki
reviewed
Jul 5, 2021
paddle/fluid/operators/roll_op.cu
Outdated
| dim_idx = (idx / strides[i]) % sizes[i]; | ||
| dim_idx_shift = (dim_idx + shifts[i]) % sizes[i]; | ||
| output_idx = output_idx + (dim_idx_shift - dim_idx) * strides[i]; | ||
| dim_idx = (idx / strides[i]) % sizes[i] + shifts[i]; |
There was a problem hiding this comment.
变量名应符合实际代表的含义，这里应该是原来的dim_idx_shift，且临时变量dim_idx不再需要，应该删除。
There was a problem hiding this comment.
不是dim_idx_shift，就是新的dim_idx位置的预估
paddle/fluid/operators/roll_op.cu
Outdated
| int64_t output_idx = idx; | ||
| int64_t dim_idx, dim_idx_shift; | ||
|
|
||
| #pragma unroll Rank |
added 3 commits
July 6, 2021 05:05
… roll_optimize_kernel
… roll_optimize_kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
optimize the index computation
Paddle vs Pytorch
axis=(1)
shift=(5)
axis=(0)
shift=(5)
axis=(0,1)
shift=(5,5)