Skip to content

Conversation

fengxiaoshuai
Copy link
Contributor

@fengxiaoshuai fengxiaoshuai commented Jun 16, 2021

PR types

Others

PR changes

Others

Describe

Add squared_mat_sub_fuse_pass

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@fengxiaoshuai fengxiaoshuai changed the title Add squared_mat_sub_fuse_pass , elementwise_mul.pbtxt and square.pbtxt Add squared_mat_sub_fuse_pass notest,test=coverage Jun 17, 2021
@fengxiaoshuai fengxiaoshuai reopened this Jun 17, 2021
@fengxiaoshuai fengxiaoshuai changed the title Add squared_mat_sub_fuse_pass notest,test=coverage Add squared_mat_sub_fuse_pass Jun 17, 2021
name: "op_device"
type: STRING
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件的最后面留一个空行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

.AddOutput("Out")
.IsTensor()
.End()
.AddAttr("dtype")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确认一下dtype的取值范围,应该还有一个最大值的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

.AddAttr("shape")
.End()
.AddAttr("value")
.End();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value没有约束条件的话。补充个注释说明一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释已经修改

winter-wang
winter-wang previously approved these changes Jun 18, 2021
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 20eafd7 into PaddlePaddle:develop Jun 22, 2021
@fengxiaoshuai fengxiaoshuai deleted the squared_mat_sub_fuse_pass branch July 1, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants