Skip to content

Conversation

Jiangxinz
Copy link
Contributor

@Jiangxinz Jiangxinz commented Jun 11, 2021

PR types

Bug fixes

PR changes

Others

Describe

  1. In python/paddle/fluid/tests/unittests/test_fleet_metric.py:
    Line 38: Bad first argument 'UtilBase' given to super()
    use 'FakeUtil' instead of 'UtilBase'
  2. In python/paddle/fluid/entry_attr.py:
    Line 43, 60: Bad first argument 'EntryAttr' given to super()
    use 'ProbabilityEntry' instead of 'EntryAttr'
    use 'CountFilterEntry' instead of 'EntryAttr'
  3. In python/paddle/distributed/entry_attr.py:
    Line 85, 125: Bad first argument 'EntryAttr' given to super()
    use 'ProbabilityEntry' instead of 'EntryAttr'
    use 'CountFilterEntry' instead of 'EntryAttr'
  4. In python/paddle/fluid/tests/unittests/test_backward.py:
    Line 163, 333: Bad first argument 'BackwardNet' given to super()
    use 'SimpleNet' instead of 'BackwardNet'
    use 'ConditionalNet' instead of 'BackwardNet'
  5. In python/paddle/fluid/tests/unittests/test_fleet_rolemaker_2.py:
    Line 202: Bad first argument 'Fleet' given to super()
    use 'TmpFleet' instead of 'Fleet'
  6. In python/paddle/fluid/tests/unittests/mkldnn/test_conv2d_transpose_mkldnn_op.py:
    Line 138: Bad first argument 'TestMKLDNNWithValidPad' given to super()
    use 'TestMKLDNNWithValidPad_NHWC' instead of 'TestMKLDNNWithValidPad'
  7. In python/paddle/fluid/incubate/fleet/base/role_maker.py
    Line 594: Bad first argument 'RoleMakerBase' given to super()
    use 'GeneralRoleMaker' instead of 'RoleMakerbase'

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 78a9870 into PaddlePaddle:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants