Skip to content

Make PADDLE_ENFORCE and PADDLE_THROW catchable #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 25, 2017

  • Use EnforceNotMet to unify all exception types.

@reyoung reyoung requested a review from gangliao July 25, 2017 09:00
@reyoung reyoung force-pushed the feature/unify_enforce_error_to_make_it_catchable branch 2 times, most recently from 29464d8 to 273f3ea Compare July 25, 2017 09:02
* Use EnforceNotMet to unify all exception types.
@reyoung reyoung force-pushed the feature/unify_enforce_error_to_make_it_catchable branch from 273f3ea to e3f5fdc Compare July 25, 2017 09:05
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangliao gangliao merged commit 2f6e7a5 into PaddlePaddle:develop Jul 26, 2017
@reyoung reyoung deleted the feature/unify_enforce_error_to_make_it_catchable branch August 2, 2017 11:35
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants