Generating python protobuf for paddle.v2.framework #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
force-pushed
the
feature/v2_framework_for_python
branch
5 times, most recently
from
f6dc08a to
3d88504
Compare
reyoung
force-pushed
the
feature/v2_framework_for_python
branch
5 times, most recently
from
9c7e551 to
9293625
Compare
Python should be able to manipulate Protobuf message because:
1. Python's `create_op_creation_methods` take the `OpProto` array to
generate all `op_creation_methods` in RunTime.
2. All `op_creation_methods` will create an `OpDesc` and pass it to
Paddle C++ method `CreateOp` and return the Op handle.
Here is the list of what is added in this commit:
* Add `protobuf_generate_python` if it is not defined.
* Before cmake 3.4, `protobuf_generate_python` is not defined. Just
copy the implementation of that function in `protobuf.cmake`
* Add `py_proto_compile` function in `cmake/generic.cmake`.
* It follows bazel's API interface.
* https://github.com/pubref/rules_protobuf#rules
* Add an empty package named `paddle.v2.framework`, all python code of
`paddle::framework` will be in that package.
* Generate protobuf's python module `__init__.py` by `touch` while
compiling.
* Change setup.py.in, make `paddle.v2.framework.proto` uses the
generated protobuf pythons.
reyoung
force-pushed
the
feature/v2_framework_for_python
branch
from
9293625 to
e2ea1f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python should be able to manipulate Protobuf message because:
Python's
create_op_creation_methodstake theOpProtoarray togenerate all
op_creation_methodsin RunTime.All
op_creation_methodswill create anOpDescand pass it toPaddle C++ method
CreateOpand return the Op handle.Here is the list of what is added in this commit:
py_proto_compilefunction incmake/generic.cmake.paddle.v2.framework, all python code ofpaddle::frameworkwill be in that package.__init__.pybytouchwhilecompiling.
paddle.v2.framework.protouses thegenerated protobuf pythons.