Skip to content

FIX: Add eigen and any as INTERFACE deps #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 4, 2017
Merged

FIX: Add eigen and any as INTERFACE deps #2733

merged 5 commits into from
Jul 4, 2017

Conversation

gangliao
Copy link
Contributor

@gangliao gangliao commented Jul 4, 2017 •
edited
Loading

fix #2727

@gangliao gangliao requested a review from QiJune July 4, 2017 05:26
@gangliao gangliao requested a review from reyoung July 4, 2017 05:27
@QiJune
Copy link
Member

QiJune commented Jul 4, 2017

So, which one should we use? DEPS eigen3 or DEPS extern_eigen3?

@gangliao
Copy link
Contributor Author

gangliao commented Jul 4, 2017

This PR only works under CMake >= 3.3, trying to find another way to support.

QiJune
QiJune approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangliao gangliao merged commit 1e02494 into PaddlePaddle:develop Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees

@reyoung reyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nv_test could not add_dependencies of header-ONLY library
3 participants
@gangliao @QiJune @reyoung