Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename paddle::strings::StringPiece into paddle::string::Piece #2657

Merged
merged 2 commits into from
Jun 29, 2017

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Jun 28, 2017

So we can write the following in paddle/framework/operator.h or somewhere in the paddle namespace:

namespace paddle {
namespace framework {
namespace detail {
namespace whatever {
...
string::Piece p = string::Printf("%2.2f", 12,345);
...

C++ compiler would be able to find out a parent namespace, which will be ::paddle, that has string::Piece.

For a verification please see https://gist.github.com/wangkuiyi/0bb245a71d3dcfc77e1e4d6961023033.

Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangkuiyi wangkuiyi merged commit 95cda82 into PaddlePaddle:develop Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants