-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pserver test #2630
fix pserver test #2630
Conversation
I checked out this PR, but it also failed with $ go test ./...
? github.com/PaddlePaddle/Paddle/go/cmd/master [no test files]
? github.com/PaddlePaddle/Paddle/go/cmd/pserver [no test files]
? github.com/PaddlePaddle/Paddle/go/connection [no test files]
ok github.com/PaddlePaddle/Paddle/go/master 0.991s
? github.com/PaddlePaddle/Paddle/go/master/c [no test files]
signal: killed
FAIL github.com/PaddlePaddle/Paddle/go/pserver 0.008s
? github.com/PaddlePaddle/Paddle/go/pserver/cclient [no test files]
ok github.com/PaddlePaddle/Paddle/go/utils/networkhelper 0.019s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
confirmed. |
@Yancey1989 you need to upgrade go to > 1.8.1, this was a go bug. Thanks @typhoonzero , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.