Skip to content

Conversation

@baiyfbupt
Copy link
Contributor

@baiyfbupt baiyfbupt commented Aug 10, 2020

PR types

Others

PR changes

APIs

Describe

  1. Add nn.functional.mse_loss and corresponding unittest

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@baiyfbupt baiyfbupt requested a review from zhiqiu August 11, 2020 11:39
@baiyfbupt baiyfbupt closed this Aug 12, 2020
@baiyfbupt baiyfbupt reopened this Aug 12, 2020
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
A small issue, what about the performance of the combination of small layers(ops)?

@baiyfbupt baiyfbupt closed this Aug 14, 2020
@baiyfbupt baiyfbupt reopened this Aug 14, 2020
@baiyfbupt
Copy link
Contributor Author

image

@baiyfbupt baiyfbupt requested a review from yaoxuefeng6 August 14, 2020 06:21
@baiyfbupt baiyfbupt merged commit 22b06db into PaddlePaddle:develop Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants