modify flip test=develop #25312
Merged
modify flip test=develop #25312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jiweibo
reviewed
Jul 8, 2020
jzhang533
reviewed
Jul 9, 2020
Contributor
jzhang533
left a comment
jzhang533
left a comment
There was a problem hiding this comment.
另一个APIpaddle.reverse，跟flip做的事情是一样的，但paddle.reverse不支持动态图。
paddle.reverse的实现可以废弃掉，建立一个alias指向flip即可。
|
|
||
|
|
||
| def flip(input, dims, name=None): | ||
| def flip(x, axis, name=None): |
liym27
approved these changes
Jul 14, 2020
Contributor
liym27
left a comment
liym27
left a comment
There was a problem hiding this comment.
LGTM for the changes of Attrs of flip op. Please node that it will cause that Paddle inference library of 2.0 version to load model trained by the old version failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixesPR changes
APIsDescribe
According to paddle 2.0 standard
1, change flip api attr name 'dim' to 'axis'.
2, support empty axis
3, change example code to imperative mode.