Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test=develop, bug fix for trainer_factory #22751

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

123malin
Copy link
Contributor

@123malin 123malin commented Feb 25, 2020

修复语法错误:
trainer_factory._create_trainer方法中,判断是否用默认值的方法是:opt_info == None;该写法无法正确识别opt_info 为空字符、空字典、空列表等case。

@123malin 123malin closed this Feb 25, 2020
@123malin 123malin reopened this Feb 25, 2020
Copy link
Collaborator

@seiriosPlus seiriosPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@123malin 123malin merged commit 0cb121c into PaddlePaddle:develop Feb 26, 2020
123malin added a commit to 123malin/Paddle that referenced this pull request Mar 5, 2020
@123malin 123malin mentioned this pull request Mar 5, 2020
123malin added a commit that referenced this pull request Mar 5, 2020
* test=develop, bug fix for trainer_factory (#22751)

* test=develop, optimize distributedstrategy (#22677)
@123malin 123malin deleted the bug_fix branch March 23, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants