Optimize fleet API: add input check for some interfaces #18971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiriosPlus
changed the title
frankwhzhang
approved these changes
Sep 6, 2019
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
…#18971) * fleet api add input check, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
优化fleet API，给部分接口增加输入check，对用户的输入做一些限定，从而避免因输入不当导致的运行失败，优化的fleet API主要包括：
1）DistributeTranspilerConfig，对sync_mode、runtime_split_send_recv这两个配置参数新增setter修饰器，从而避免其被设置为None而导致的程序出错
2）UserDefinedRoleMaker和UserDefinedCollectiveRoleMaker的构造函数中，增加对current_id, worker_num, role, server_endpoints等的检查