Fix bad code in c plus and python #11317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guochaorong
commented
Jun 8, 2018
| @@ -130,8 +130,6 @@ void CUPTIAPI bufferRequested(uint8_t **buffer, size_t *size, | |||
| uint8_t *buf = reinterpret_cast<uint8_t *>(malloc(kBufSize + kAlignSize)); | |||
| *size = kBufSize; | |||
| *buffer = ALIGN_BUFFER(buf, kAlignSize); | |||
| free(buf); | |||
There was a problem hiding this comment.
I didn't notice that it was requesting a buffer.... and I found that has been freed through the cuptiActivityRegisterCallbacks ， and finally freed at the end of bufferCompleted function.
There was a problem hiding this comment.
It is a typical false alarm reported by cppcheck analysis tool.
panyx0718
approved these changes
Jun 9, 2018
|
nice! We can discuss about this tool later. |
|
Thank you. It's my pleasure to discuss it with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am wondering if the script python/paddle/fluid/layers/metric.py have been used so far. the ‘auc’ method in it seems does not work.