Skip to content

create hierarchical_layer_en.rst #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

create hierarchical_layer_en.rst #10304

wants to merge 2 commits into from

Conversation

shadowimp
Copy link

@shadowimp shadowimp commented May 1, 2018 •
edited by shanyi15
Loading

fix #9014

@CLAassistant
Copy link

CLAassistant commented May 1, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

abhinavarora
abhinavarora suggested changes May 2, 2018
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the language in this document is very bad. Please close this PR. I will create a new PR with better English using ideas from this PR.

doc/v2/howto/rnn/hierarchical_layer_en.rst
summary
=======

The sequence is common data structure in the proccess of NLP(nature language proccess). A single word can be seem as a non-sequence input or a zero-layer input. The sentence make up by words is a one-layer sequence and the senten is a two-layer squence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequence is common -> A sequence is a common

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nature language proccess -> Natural Language Processing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not make sense -> A single word can be seem as a non-sequence input or a zero-layer input.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanyi15

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get, thanks!

@shanyi15
Copy link
Collaborator

shanyi15 commented May 2, 2018

Thank you for your contribution @shadowimp ，however, since the language problem according to @abhinavarora 's comment, please close this PR and we'll open a new one.

@shadowimp shadowimp closed this May 2, 2018
@skylarch skylarch mentioned this pull request Jun 7, 2018
Merged
kuke pushed a commit to kuke/Paddle that referenced this pull request Aug 25, 2018
@skylarch
Update hierarchical_layer_en.rst
fcea0e0 
fix PaddlePaddle#9014 and PaddlePaddle#10304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavarora abhinavarora abhinavarora requested changes

@shanyi15 shanyi15 shanyi15 left review comments

Assignees
No one assigned
Labels
translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation Plan-支持双层序列作为输入的layer-汉译英
4 participants
@shadowimp @CLAassistant @shanyi15 @abhinavarora