Skip to content

Added auto transform to beam_search_decode_op #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2018

Conversation

ktlichkid
Copy link

@ktlichkid ktlichkid commented Apr 28, 2018

Resolve #10289

@ktlichkid ktlichkid force-pushed the decode-auto-transform branch from cba695a to 4c69107 Compare April 28, 2018 09:29
@ktlichkid ktlichkid force-pushed the decode-auto-transform branch from 3075a7e to 27b6a67 Compare April 28, 2018 11:36
@ktlichkid ktlichkid requested a review from jacquesqiao April 28, 2018 11:38
@ktlichkid ktlichkid changed the title [WIP] Added auto transform to beam_search_decode_op Added auto transform to beam_search_decode_op Apr 28, 2018
@jacquesqiao
Copy link
Member

Please add unit test for this change.

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ktlichkid ktlichkid merged commit 3bb99c4 into PaddlePaddle:develop May 4, 2018
@ktlichkid ktlichkid deleted the decode-auto-transform branch May 4, 2018 06:38
@ktlichkid
Copy link
Author

If step_ids and step_scores are on different devices, there might be troubles. That is very rare though. Will fix it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants