Support excluded and included mode for average pooling. #10235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
reviewed
Apr 27, 2018
paddle/fluid/operators/pool_op.cc
Outdated
| "exclude_mode", | ||
| "(bool, default True) Whether to exclude the padding cells when " | ||
| "calculating, but only work when pooling_type is avg. The defalut " | ||
| "is exclude mode.") |
There was a problem hiding this comment.
Can we have more detail description here.
how does exclude_mode play with pooling_type
Should this be called exclude_padding?
There was a problem hiding this comment.
Update the description and change name to exclude_pad, which is more clear. Thanks very much! @panyx0718
qingqing01
force-pushed
the
pooling
branch
2 times, most recently
from
4099b22 to
1f13d95
Compare
panyx0718
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10234
Also, fix the cpplint.