refine FLAGS approval

sneaxiy · sneaxiy · commit ad76e4a3c6cf · 2021-09-22T13:24:52.000+08:00
diff --git a/tools/check_file_diff_approvals.sh b/tools/check_file_diff_approvals.sh
@@ -88,7 +88,7 @@ function run_tools_test() {
     cd ${CUR_PWD}
 }
 
-changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle | grep -E 'DEFINE_EXPORTED|DEFINE_bool|DEFINE_int32|DEFINE_int64|DEFINE_uint64|DEFINE_double|DEFINE_string' | wc -l`
+changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle | grep 'DEFINE_EXPORTED' | wc -l`
 if [[ $changed_env_var_count -gt 0 ]]; then
     echo_line="You must have one RD (lanxianghit (Recommend), phlrain or luotao1) approval for changing the FLAGS, which manages the environment variables.\n"
     check_approval 1 6836917 47554610 43953930

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ function run_tools_test() {`
`88`	`88`	`cd ${CUR_PWD}`
`89`	`89`	`}`
`90`	`90`
`91`		-changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle \| grep -E 'DEFINE_EXPORTED\|DEFINE_bool\|DEFINE_int32\|DEFINE_int64\|DEFINE_uint64\|DEFINE_double\|DEFINE_string' \| wc -l`
	`91`	+changed_env_var_count=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/paddle \| grep 'DEFINE_EXPORTED' \| wc -l`
`92`	`92`	`if [[ $changed_env_var_count -gt 0 ]]; then`
`93`	`93`	`echo_line="You must have one RD (lanxianghit (Recommend), phlrain or luotao1) approval for changing the FLAGS, which manages the environment variables.\n"`
`94`	`94`	`check_approval 1 6836917 47554610 43953930`