Add model SCRFD support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ziqi-jin
commented
Aug 3, 2022
•
ziqi-jin
commented
- Face detection model SCRFD
- supply the decoding process when the exported ONNX file includes face key points or not
- add is_dynamic support for all yolo series
DefTruth
requested changes
Aug 3, 2022
DefTruth
requested changes
Aug 3, 2022
| } | ||
|
|
||
| void SCRFD::GeneratePoints() { | ||
| if (center_points_is_update_ && !is_dynamic_input_) return; |
There was a problem hiding this comment.
这里也改成统一的风格吧
if (center_points_is_update_ && !is_dynamic_input_) {
return;
}| float* landmarks_ptr = | ||
| static_cast<float*>(infer_result.at(f + 2 * fmc).Data()); | ||
| // landmarks | ||
| const float* kps_offsets = landmarks_ptr + i * 10; |
There was a problem hiding this comment.
这句也应该是用landmarks_per_face * 2来计算地址
const float* kps_offsets = landmarks_ptr + i * 10;
// 改成
const float* kps_offsets = landmarks_ptr + i *(landmarks_per_face * 2);| bool center_points_is_update_; | ||
|
|
||
| // feature map count | ||
| unsigned int fmc; |
There was a problem hiding this comment.
fmc 和 center_points都是私有的，都加一下下划线吧
DefTruth
requested changes
Aug 3, 2022
DefTruth
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.