Skip to content

Implement Greeting Display Functionality (Front-End) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

PabloBona
Copy link
Owner

@PabloBona PabloBona commented Oct 25, 2023

Description:
This pull request addresses the following requirements for the Hello React Front-End project:

  • Create a React app called 'hello-react-front-end'.
    • The React app has been created and named as 'hello-react-front-end'.
  • Initialize the project with Git.
    • The project has been initialized with Git, and the initial commit has been made.
  • Create the App component with react-router.
    • The App component has been created, and react-router has been set up to manage routes within the application.
  • Create the Greeting component that displays a greeting and set it up as a route in the App component.
    • The Greeting component has been implemented and integrated as a route in the App component.
  • Create a store, an action, and a reducer that connect to your API endpoint to get the random greeting.
    • A Redux store has been implemented, along with an action and a reducer. These components connect to the Rails API endpoint to fetch random greetings.
  • Display the random greeting in your Greeting component.
    • The random greeting obtained from the API endpoint is successfully displayed in the Greeting component.

    This front-end application is designed to work in conjunction with the Hello Rails Back-End project.
    This is the PR for the back-end

@PabloBona PabloBona changed the title Implement Greeting Display Functionality Implement Greeting Display Functionality (Front-End) Oct 25, 2023
Copy link

@cynthiainga cynthiainga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PabloBona,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • There is an App component with routes ✔️
  • There is a Greeting component ✔️
  • Correct Gitflow ✔️
  • No linters errors ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants