Skip to content

🌟 [Major]: Cleanup outputs + Bump and align with Invoke-Pester@v3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Feb 23, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Feb 23, 2025

Description

This pull request introduces significant changes to the GitHub Actions workflows and some configuration files. The main objective is to consolidate multiple workflow files into a single file and update the configurations accordingly. Here are the most important changes:

The action itself

  • action.yml:
    • Updated to use PSModule/Invoke-Pester@v3 instead of PSModule/Invoke-Pester@v2
    • Removed the outputs section🌟.

Consolidation of Workflows

  • .github/workflows/Action-Test.yml: Added a new workflow file that consolidates multiple workflows into one, handling different test types such as Src-SourceCode, Src-Custom, Src-WithManifest, and outputs. This file also includes a new job CatchJob to aggregate the status of all tests.

Removal of Redundant Workflow Files:

  • Removed the following workflow files as they are consolidated into the Action-Test.yml
    • .github/workflows/Action-Test-Src-Default-Custom.yml
    • .github/workflows/Action-Test-Src-Default.yml
    • .github/workflows/Action-Test-Src-WithManifest.yml
    • .github/workflows/Action-Test-outputs.yml

Test and Script Updates

  • scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1:
    • Refactored the script to improve readability and logging, including changes to how paths are resolved and how test results are logged.
  • Added a failing test to see that the action actually will detect failures.
    • Removed the SuppressMessageAttribute for the Set-PSModuleTest function in tests/srcWithManifestTestRepo/src/functions/public/SomethingElse/Set-PSModuleTest.ps1.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Feb 23, 2025
…nalyzer tests for improved clarity and logging
…gregation and add a new script for result processing
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Bump Invoke-Pester to v3 🌟 [Major]: Cleanup outputs + Bump Invoke-Pester to v3 Feb 23, 2025
@MariusStorhaug MariusStorhaug changed the title 🌟 [Major]: Cleanup outputs + Bump Invoke-Pester to v3 🌟 [Major]: Cleanup outputs + Bump and align with Invoke-Pester@v3 Feb 23, 2025
@MariusStorhaug MariusStorhaug merged commit 1ea7523 into main Feb 23, 2025
10 checks passed
@MariusStorhaug MariusStorhaug deleted the bumpPester branch February 23, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant