Add opponent to both direct chat serializers

Author: yakser

chats/serializers.py

@@ -14,7 +14,7 @@ class DirectChatListSerializer(serializers.ModelSerializer):
     last_message = serializers.SerializerMethodField()
     opponent = serializers.SerializerMethodField()
 
-    def get_opponent(self):
+    def get_opponent(self, chat: DirectChat):
         user = self.context.get("opponent")
         return UserDetailSerializer(user).data
 
@@ -32,17 +32,17 @@ class Meta:
 
 
 class DirectChatDetailSerializer(serializers.ModelSerializer):
-    users = serializers.SerializerMethodField(read_only=True)
+    opponent = serializers.SerializerMethodField()
 
-    @classmethod
-    def get_users(cls, chat: DirectChat):
-        return UserListSerializer(chat.get_users(), many=True).data
+    def get_opponent(self, chat: DirectChat):
+        user = self.context.get("opponent")
+        return UserDetailSerializer(user).data
 
     class Meta:
         model = DirectChat
         fields = [
             "id",
-            "users",
+            "opponent",
         ]
 
 

chats/views.py

@@ -36,6 +36,31 @@ def get_queryset(self):
         user = self.request.user
         return user.direct_chats.all()
 
+    def get(self, request, *args, **kwargs):
+        chats = self.get_queryset()
+        serialized_chats = []
+        for chat in chats:
+            # fixme: move to function like get_user() and get_opponent()
+            chat_id = chat.id
+            user1_id, user2_id = map(int, chat_id.split("_"))
+
+            try:
+                user1 = User.objects.get(pk=user1_id)
+                user2 = User.objects.get(pk=user2_id)
+            except User.DoesNotExist:
+                # fixme: show deleted profile
+                continue
+
+            if user1 == request.user:
+                opponent = user2
+            else:  # fixme: if user1 == user2
+                opponent = user1
+
+            context = {"opponent": opponent}
+            serialized_chat = DirectChatListSerializer(chat, context=context).data
+            serialized_chats.append(serialized_chat)
+        return Response(serialized_chats, status=status.HTTP_200_OK)
+
 
 class ProjectChatList(ListAPIView):
     serializer_class = ProjectChatListSerializer
@@ -72,8 +97,6 @@ def get(self, request, *args, **kwargs) -> Response:
 
             if user1 == request.user:
                 opponent = user2
-                # may be is better to use serializer or return dict -
-                # {"first_name": user2.first_name, "last_name": user2.last_name}
             else:
                 opponent = user1
             context = {"opponent": opponent}