Default ambient for 3.8 and above #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n or as the first statement of the scene, the default ambient finish is set to 0.0 (instead of 0.1 which is problematic with gamma handling rgb vs srgb)
|
:-) Typo - not yours - fixed and everything! |
|
Looks like you also addressed the INI / command-line version override already, so nothing to complain from my side. Presuming nobody finds other issues we've missed, I'm ready to pull as soon as the general go-ahead is given. |
c-lipka
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When version is set as the first statement of the scene or via option, and the version is 3.8 or more, the default ambient is 0 instead of the previous 0.1 which has problem with the gamma handling.